Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2092 +/- ##
==========================================
+ Coverage 52.18% 52.19% +0.01%
==========================================
Files 390 391 +1
Lines 41944 41953 +9
Branches 7772 7774 +2
==========================================
+ Hits 21888 21897 +9
Misses 19279 19279
Partials 777 777
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pieqq
approved these changes
Aug 27, 2025
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
Neat!
We really need to start documenting high-level functions from checkbox_support that test developers can make use of...
bladernr
pushed a commit
that referenced
this pull request
Aug 27, 2025
API to read the machine manifest
bladernr
pushed a commit
that referenced
this pull request
Aug 28, 2025
API to read the machine manifest
stanley31huang
pushed a commit
that referenced
this pull request
Oct 3, 2025
API to read the machine manifest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It may be increasingly important to be able to take actions in tests depending on the state of manifests. This is true both while testing (for example, nvidia vs amd tests, we may have a "shared" smoke) and in setup (we can use the same code to install drivers for different cards. Additionally, at launch setup jobs will not have the manfiest reading functionality, this allows the users to still rely on manifests inside their jobs.
Resolved issues
Fixes:
Documentation
N/A
Tests
Added tests for the functionality.