Skip to content

plainbox:execution: Fix warning message format issue (BugFix)#2095

Merged
Hook25 merged 1 commit intocanonical:mainfrom
Cypresslin:execution-warn-msg
Aug 28, 2025
Merged

plainbox:execution: Fix warning message format issue (BugFix)#2095
Hook25 merged 1 commit intocanonical:mainfrom
Cypresslin:execution-warn-msg

Conversation

@Cypresslin
Copy link
Copy Markdown
Contributor

Description

The multi-line warning message will need an extra space at the end or the eginning of the line, otherwise it will print something like:

Please store desired files in $PLAINBOX_SESSION_SHAREand use regular temporary files for everything else

Resolved issues

Described above.

Documentation

Tests

With this fix the warning message won't stick together:

Please store desired files in $PLAINBOX_SESSION_SHARE and use regular temporary files for everything else

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.22%. Comparing base (17199c9) to head (320cf6b).
⚠️ Report is 89 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2095   +/-   ##
=======================================
  Coverage   52.22%   52.22%           
=======================================
  Files         391      391           
  Lines       41950    41950           
  Branches     7773     7773           
=======================================
  Hits        21908    21908           
  Misses      19265    19265           
  Partials      777      777           
Flag Coverage Δ
checkbox-ng 70.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hook25
Copy link
Copy Markdown
Collaborator

Hook25 commented Aug 28, 2025

thanks!

@Hook25
Copy link
Copy Markdown
Collaborator

Hook25 commented Aug 28, 2025

Please sign your commits

The multi-line warning message will need an extra space at the end or the
eginning of the line, otherwise it will print something like:
    Please store desired files in $PLAINBOX_SESSION_SHAREand use regular
    temporary files for everything else

Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
@Cypresslin
Copy link
Copy Markdown
Contributor Author

Please sign your commits

Done, thank you.

@Hook25 Hook25 merged commit dfbe7f3 into canonical:main Aug 28, 2025
20 checks passed
bladernr pushed a commit that referenced this pull request Aug 28, 2025
plainbox:execution: Fix warning message format issue

The multi-line warning message will need an extra space at the end or the
eginning of the line, otherwise it will print something like:
    Please store desired files in $PLAINBOX_SESSION_SHAREand use regular
    temporary files for everything else

Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
stanley31huang pushed a commit that referenced this pull request Oct 3, 2025
plainbox:execution: Fix warning message format issue

The multi-line warning message will need an extra space at the end or the
eginning of the line, otherwise it will print something like:
    Please store desired files in $PLAINBOX_SESSION_SHAREand use regular
    temporary files for everything else

Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants