Add machine manifest to submission JSON (New)#2100
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2100 +/- ##
=======================================
Coverage 52.23% 52.24%
=======================================
Files 391 391
Lines 41960 41966 +6
Branches 7774 7774
=======================================
+ Hits 21918 21924 +6
Misses 19266 19266
Partials 776 776
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b12242c to
cf4e05f
Compare
Hook25
previously approved these changes
Sep 2, 2025
Collaborator
|
Any reason why you didnt use this: |
Hook25
approved these changes
Sep 2, 2025
stanley31huang
pushed a commit
that referenced
this pull request
Oct 3, 2025
* Add machine manifest to submission JSON Fix CHECKBOX-2001 * Add unit tests * Use built-in Checkbox version * Use existing helper to get manifest file path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the content of
/var/tmp/checkbox-ng/machine-manifest.json(aka the machine manifest) to the submission JSON as part of the system_information gathering mechanism.This information was already present as part of the submission, but in a very awkward format (Checkbox job output). The following PR adds a
machine_manifestsection to thesystem_informationsection with the JSON information about each manifest defined.Resolved issues
https://warthogs.atlassian.net/browse/CHECKBOX-2001
Documentation
N/A
Tests
Tested in a venv in the 3 different scenarios:
machine-manifest.jsonfile and not before!)In case 1, the
machine_manifestsection of thesystem_informationsection insubmission.jsonlooks like this:In cases 2 and 3, it looks something like that: