DMI sane_product missing Mini PC and fix AIO for related jobs (BugFix)#2204
Merged
DMI sane_product missing Mini PC and fix AIO for related jobs (BugFix)#2204
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2204 +/- ##
==========================================
+ Coverage 53.49% 53.65% +0.15%
==========================================
Files 401 401
Lines 43079 43188 +109
Branches 7983 8009 +26
==========================================
+ Hits 23045 23171 +126
+ Misses 19223 19205 -18
- Partials 811 812 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hanhsuan
requested changes
Nov 18, 2025
Contributor
hanhsuan
left a comment
hanhsuan
left a comment
There was a problem hiding this comment.
Could we have one new sane_product type to collect AIO to prevent the naming issue in the future ?
clairlin53
changed the title
clairlin53
changed the title
hanhsuan
previously approved these changes
Nov 24, 2025
Hook25
requested changes
Dec 16, 2025
Collaborator
Hook25
left a comment
Hook25
left a comment
There was a problem hiding this comment.
The point of the sane product was too avoid having in everywhere. Please add another attribute to the resource that tracks this set (which I assume is devices with displays)
clairlin53
force-pushed
the
bugfix_dmi_sane_product_missing_incorrect
branch
from
f11e770 to
0537a67
Compare
stanley31huang
pushed a commit
that referenced
this pull request
Dec 23, 2025
#2204) * DMI sane_product missing Mini PC and fix AIO for related jobs(Bugfix) * Fix: add missing comma in dmi_resource * Add_AIO_type * fix_test_dmi_resource_error * dmi: add display_type and update sane_product categorization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix for the PR Dmi resource sane_product to avoid in duplication (bugfix) #2046
Problem
Bug: resource.py file is missing the "Mini PC" type, causing desktop jobs to be skipped.
Bug: Graphics jobs and DIM job are skipped on AIO devices due to flawed "portable" refactor.
Description
Resolved issues
Documentation
Tests
Mini PC
Fail Result:
Manual Test:
https://certification.canonical.com/hardware/202505-36800/submission/458592/test-results/?term=glxgears
Auto Test:
https://certification.canonical.com/hardware/202505-36800/submission/456750/test-results/?term=glxgears
After modified (PASS):
Manual Test:
https://certification.canonical.com/hardware/202505-36800/submission/459713/
Auto Test:
https://certification.canonical.com/hardware/202505-36800/submission/459717/
AIO
Fail Result:
Manual:
https://certification.canonical.com/hardware/202508-37860/submission/456492/test-results/?term=dim
https://certification.canonical.com/hardware/202508-37860/submission/456492/test-results/?term=glxgears
Auto:
https://certification.canonical.com/hardware/202508-37860/submission/456467/test-results/?term=glxgears
After modified (PASS):
Manual Test:
https://certification.canonical.com/hardware/202508-37860/submission/459705/
https://certification.canonical.com/hardware/202508-37850/submission/459704/
https://certification.canonical.com/hardware/202508-37860/submission/459958/
Auto Test:
https://certification.canonical.com/hardware/202508-37860/submission/459708/
https://certification.canonical.com/hardware/202508-37860/submission/459956/