Add OpenCL-CTS to base provider (New)#2345
Merged
Hook25 merged 5 commits intocanonical:mainfrom Mar 23, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2345 +/- ##
=======================================
Coverage 57.73% 57.73%
=======================================
Files 467 467
Lines 47268 47268
Branches 8411 8411
=======================================
Hits 27292 27292
Misses 19092 19092
Partials 884 884
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mckees
force-pushed
the
opencl-cts-mainline
branch
from
a65569e to
438ca45
Compare
mckees
changed the title
Hook25
previously approved these changes
Mar 16, 2026
Collaborator
Hook25
left a comment
Hook25
left a comment
There was a problem hiding this comment.
This is ok. A few improvements to consider for a followup:
- setup/install_opencl_cts could be a
unit: setup job, that way it runs before bootstrap (and you can use the snap in bootstrap resources) - Change requires from
package.name == 'clinfo'toexecutables.name == 'clinfo'
mckees
force-pushed
the
opencl-cts-mainline
branch
from
bf5d12c to
b2dd6ee
Compare
Contributor
Author
|
A few changes:
Re-tested after these changes, and it runs as expected |
Hook25
requested changes
Mar 17, 2026
Collaborator
Hook25
left a comment
Hook25
left a comment
There was a problem hiding this comment.
Sorry I didn't quite review it correctly last time, there are a couple of things I'd like you to change before landing this. I don't even know how this validates
Hook25
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the OpenCL-CTS testing from contrib into the base proivider under graphics. The only notable difference is that all install logic and test run logic has been moved to the opencl-cts snap. I have intentionally left the job file separate because I will be submitting all of the contents of contrib/checkbox-gfx and anticipate the main jobs file getting very crowded.
Resolved issues
None
Documentation
I don't see a README with any related documentation under this provider, so I have not added any.
Tests
No tests were needed in contrib for opencl testing, so I have not created any new tests. I have validated this change by running the tests manually with
checkbox-cli run