Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2383 +/- ##
==========================================
+ Coverage 57.76% 58.29% +0.52%
==========================================
Files 467 476 +9
Lines 47299 48262 +963
Branches 8419 8613 +194
==========================================
+ Hits 27321 28133 +812
- Misses 19092 19242 +150
- Partials 886 887 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hook25
force-pushed
the
yaml_parser
branch
3 times, most recently
from
f5627e0 to
5d65942
Compare
This didnt work before because it was also forced translatable and when that was the case the forced variant check was skipped (sigh). This removes both
Minor: use list comprehension to parse resource
Minor: raise an exception instead of assert
flags weren't correctly treatedfor manual after suspend jobs because I didn't notice them. Now the code is unique so it is easier to make changes for both
fernando79513
left a comment
fernando79513
left a comment
There was a problem hiding this comment.
Great job!
If at some point we want to hard deprecate the .pxu files and clean the code, it's not going to be a super easy task, but at least all the markers you are putting for the comments will help.
Thanks for also taking care of handling properly the suspend flags, and especially the get_array_field_qualify and all the Visitors.
I run the smoke tests from the yaml and they passed no problem.
Let's see if the translated metabox tests also pass in the CI.
checkbox-ng/plainbox/impl/providers/manifest/units/manifest.yaml
Outdated
Show resolved
Hide resolved
checkbox-ng/plainbox/impl/providers/manifest/units/manifest.yaml
Outdated
Show resolved
Hide resolved
| self.assertEqual(self.validator(self.variable, name), None) | ||
|
|
||
| def test_yearless_namespace_work(self): | ||
| name = "com.canonical:certification" |
There was a problem hiding this comment.
Not from this PR, but this test doesn't do anything
|
I manually ran some YAML jobs and test/plans, and they worked fine. I think any other issues that may have slipped through should be raised during metabox tests. |
2 participants
Description
PXUs are a very outdated and weird format that scares off new contributors and makes the friction to contribute to Checkbox higher.
This PR introduces a new supported format: YAML
To begin with this transition, this translates all the pxus in Checkbox (plainbox provider) + all the pxus in metabox. The translation of the rest of the providers will be done and tested gradually in followup PRs.
Resolved issues
Fixes: CHECKBOX-1392
Documentation
N/A (Pending)
Tests
Unit + integration tested most of the additions