Open
Conversation
update manage.py nitpicks
| output_dir.mkdir(parents=True) | ||
|
|
||
| # Copy config file to SNAP_COMMON so the strict snap can access it | ||
| shutil.copy(self.config_file, DPDK_CONFIG_SNAP_PATH) |
Collaborator
There was a problem hiding this comment.
This is a great idea, I need to do this to the GPGPU test suite too...
Collaborator
pedro-avalos
left a comment
pedro-avalos
left a comment
There was a problem hiding this comment.
Looks good, submission is passing. I left a couple nitpicks/questions, but nothing blocking on my end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a new provider for running DPDK Test Suite. This is essentially a wrapper for the dpdk-dts snap to be able to execute specified test suites from Checkbox.
As a Debian package is required for server certification, using the GPGPU provider as reference for configuring this new provider
Resolved issues
CHECKBOX-2168
Documentation
Documentation will be added to the server programme once landed.
Tests
I manually build the deb package included in this PR by following the procedure in LP Docs: https://documentation.ubuntu.com/launchpad/user/how-to/source-package-recipe/#trying-it-out
After the debian package was built and installed, ran a test suite on a server with Mellanox ConnectX-6 adapter via:
test-dpdkhttps://certification.canonical.com/hardware/202303-31374/submission/477335/
Note: The failures are most likely related to a configuration error, ideally, the ports should be connected between each other but I'm using a switch configuration for simplicity.