Use checkbox-pipewire-utils default_device_is_real in test jobs (New)#2399
Open
tomli380576 wants to merge 4 commits intomainfrom
Open
Use checkbox-pipewire-utils default_device_is_real in test jobs (New)#2399tomli380576 wants to merge 4 commits intomainfrom
checkbox-pipewire-utils default_device_is_real in test jobs (New)#2399tomli380576 wants to merge 4 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2399 +/- ##
=======================================
Coverage 57.76% 57.76%
=======================================
Files 467 467
Lines 47299 47299
Branches 8419 8419
=======================================
Hits 27321 27321
- Misses 19092 19095 +3
+ Partials 886 883 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates audio job definitions to proactively fail tests when Pipewire’s current default audio devices are dummy/virtual, leveraging the new checkbox-support-pipewire-utils default_device_is_real subcommand introduced in #2317.
Changes:
- Add
checkbox-support-pipewire-utils default_device_is_realchecks (audio-sink/audio-source) to multiple audio jobs before running playback/record pipelines. - Enable
set -ein the Pipewire paths so failures in the “device is real” check abort the job immediately.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WARNING: This modifies com.canonical.certification::sru-server
Description
This PR is the 2nd half of #2317 with all the job changes.
Resolved issues
Prevents virtual devices from being used in tests
Documentation
See #2317 for code changes.
One thing to note is that we are still allowing all the audio jobs to run even if the speakers are completely not detected by the system (i.e.
audio/detect_sourcesandaudio/detect_sinksdo not use this check). This hopefully makes the results clearer, lmk what you think.Tests
Happy path: https://certification.canonical.com/hardware/202503-36476/submission/478430/
Dummy sink (virtual machine result): https://certification.canonical.com/hardware/202503-36476/submission/478750/