Add miscellanea/ubuntu-desktop-minimal-recommends job (New)#745
Merged
pieqq merged 1 commit intocanonical:mainfrom Dec 6, 2023
baconYao:dev-ubuntu-desktop-minimal-recommends
Merged
Add miscellanea/ubuntu-desktop-minimal-recommends job (New)#745pieqq merged 1 commit intocanonical:mainfrom baconYao:dev-ubuntu-desktop-minimal-recommends
pieqq merged 1 commit intocanonical:mainfrom
baconYao:dev-ubuntu-desktop-minimal-recommends
Conversation
pieqq
requested changes
Sep 26, 2023
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
Thanks for this submission!
I have a suggestion (using a default value for the shell var), as well as some wording suggestions. Please check below.
For certain IoT Desktop images, the default installation is the ubuntu-desktop-minimal package. Therefore, it is necessary to check whether its recommended packages have been installed. Ref: https://packages.ubuntu.com/jammy/ubuntu-desktop-minimal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
==========================================
+ Coverage 33.50% 34.99% +1.49%
==========================================
Files 303 302 -1
Lines 34823 34193 -630
Branches 5979 5909 -70
==========================================
+ Hits 11666 11966 +300
+ Misses 22615 21686 -929
+ Partials 542 541 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
/canonical/self-hosted-runners/run-workflows 66ef2d9 |
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
…l#745) Add miscellanea/ubuntu-desktop-minimal-recommends For certain IoT Desktop images, the default installation is the ubuntu-desktop-minimal package. Therefore, it is necessary to check whether its recommended packages have been installed. Ref: https://packages.ubuntu.com/jammy/ubuntu-desktop-minimal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For certain IoT Desktop images, the default installation is the ubuntu-desktop-minimal package. Therefore, it is necessary to check whether its recommended packages have been installed.
Ref: https://packages.ubuntu.com/jammy/ubuntu-desktop-minimal
Resolved issues
N/A
Documentation
N/A
Tests
Sideload result on Baoshan Project and the information of
apt-cache show ubuntu-desktop-minimal:CID: 202309-32022
Image: iot-baoshan-classic-desktop-2204-genio-desktop-09-01-20230908-116