Added a checkbox-shell flag (BugFix)#871
Merged
Merged
Conversation
When running checkbox shell-wrapper, a flag with "(checkbox-shell)" is added before the prompt
kissiel
approved these changes
Jan 10, 2024
Contributor
kissiel
left a comment
kissiel
left a comment
There was a problem hiding this comment.
The more I think about it, the more I see how much off I was :)
Indeed, this looks like the right way forward!
Thanks for the great explanation!
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
Added a checkbox-shell flag When running checkbox shell-wrapper, a flag with "(checkbox-shell)" is added before the prompt
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
Added a checkbox-shell flag When running checkbox shell-wrapper, a flag with "(checkbox-shell)" is added before the prompt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running checkbox shell-wrapper, a flag with
"(checkbox-shell)" is added before the prompt
Description
A new
(checkbox-support)flag added when running a shell wrapper.Resolved issues
Closes issue #163
Documentation
No documentation update. The shell-wrapper script works the same way as the previous one.
Tests
To test theses changes, go to
checkbox-snap/common_series_classes/launchersand run:The shell wrapper should output
(checkbox-shell)before the prompt.Alternatively, build the checkbox snap, install it and run: