Merged
Conversation
Minor: removed old scripts
kissiel
approved these changes
Dec 7, 2023
Contributor
kissiel
left a comment
kissiel
left a comment
There was a problem hiding this comment.
I really appreciate the much improved wording of steps!
+1
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
* New deb daily build workflow Minor: removed old scripts * Make file executable and add shebang * Clone and install dependencies * Better name for ppa_update * Better name for ppa_build * Improved step name * Missing extension of get_version * Add export command and update command line args * Un-split command of lp_update_recipe * Give up on nice command * Compatibility with py3.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor: removed old scripts
Description
We have landed all the new scripts for our deb release process, this PR calls the new scripts from the workflow and removes the old ones.
Resolved issues
Resolves: https://warthogs.atlassian.net/browse/CHECKBOX-1058
Documentation
N/A
Tests
This PR introduces the new workflow, I will call it from this branch and validate the results, all pieces are already unit tested.