Move ISHTP and ECLITE test cases and plans from iiotg provider and checkbox-iiotg-provder (New)#895
Merged
pieqq merged 3 commits intocanonical:mainfrom Jan 9, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #895 +/- ##
==========================================
+ Coverage 36.54% 36.74% +0.20%
==========================================
Files 310 310
Lines 34634 34632 -2
Branches 5964 5964
==========================================
+ Hits 12656 12725 +69
+ Misses 21408 21337 -71
Partials 570 570
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Collaborator
|
/canonical/self-hosted-runners/run-workflows d151cec |
LiaoU3
force-pushed
the
migrate_iotg_ishtp
branch
from
d151cec to
2e0fae5
Compare
LiaoU3
changed the title
LiaoU3
force-pushed
the
migrate_iotg_ishtp
branch
from
2e0fae5 to
f822f6f
Compare
pieqq
previously approved these changes
Jan 9, 2024
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
Looks good!
I left a few comments for you to review, but overall this PR looks fine.
…itz into shell script
LiaoU3
force-pushed
the
migrate_iotg_ishtp
branch
from
35b8f25 to
2b627fa
Compare
LiaoU3
added a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
canonical#895) * Move ISHTP and ECLITE test cases from checkbox-iiotg-provider and iiotg provider * Put the command field for eclite/temperature-reading-from-thermal-acpitz into shell script * Add estimated_duration for the job eclite/temperature-reading-from-thermal-acpitz
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
canonical#895) * Move ISHTP and ECLITE test cases from checkbox-iiotg-provider and iiotg provider * Put the command field for eclite/temperature-reading-from-thermal-acpitz into shell script * Add estimated_duration for the job eclite/temperature-reading-from-thermal-acpitz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I move the ISHTP and ECLITE related test jobs and plans from checkbox-provider-intliotg and
iiotgprovider tobaseprovider.Resolved issues
N/A
Documentation
N/A
Tests
I ran the testplan
ishtp-fullor you could sayIntel Integrated Sensor Hub Transport Protocol (ISHTP) tests (Full)on EHL (202306-31657) and TGL (202306-31658).TGL (202306-31658) only supports
ISHTP, so theECLITErelated jobs was skipped.submission: https://certification.canonical.com/hardware/202306-31658/submission/348274/
EHL (202306-31657) support both
ISHTPandECLITE, however it still has some bugs with them (LP#2027657), so the jobs failed in the submission.submission: https://certification.canonical.com/hardware/202306-31657/