Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #897 +/- ##
=======================================
Coverage 36.54% 36.55%
=======================================
Files 310 310
Lines 34634 34639 +5
Branches 5964 5965 +1
=======================================
+ Hits 12656 12661 +5
Misses 21408 21408
Partials 570 570
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Jan 9, 2024
* Fix pending binary builds * Rolled back comment update * New test for unknown buildstatus * Motivate time sleep everywhere
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
* Fix pending binary builds * Rolled back comment update * New test for unknown buildstatus * Motivate time sleep everywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This run of daily builds failed because the
date_first_dispatchedattribute of a build is filled only once it is actually started, therefore if a build is pending it will be None. This fixes this issue and adds a sanity check on the build status (currently we can not determine how that field is filled for pending builds AND we want to resist/know spurious values in there so that we can proactively fix the script if they come up).Resolved issues
This build fail
Documentation
This explains why the
Nonecase is included in the selector in a comment both in the function and in the testTests
The new value is now included in the function test.