Disable fail fast in deb daily build (infra)#898
Merged
Conversation
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Jan 9, 2024
Disable fail fast in deb daily build
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
Disable fail fast in deb daily build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Given that every workflow monitors and tries to get as many builds as possible landed in the PPA, killing them all if one fails is not a great idea. Doing so disrupts the monitor->retry loop and removes the information from the daily build log about which ppa(s) failed specifically (namely if checkbox-ng and checkbox-support fail while all the others pass, the daily builds workflow will list 1 failures and all the others cancelled or a few pass, a few cancelled and 1 fail).
Resolved issues
We can not determine from yesterday's build which PPAs are currently ok and which need some additional attention.
Documentation
N/A
Tests
N/A