Skip to content

Add QEP test cases and plans from checkbox-iiotg-providers and iiotg provider (New)#901

Merged
pieqq merged 3 commits intocanonical:mainfrom
LiaoU3:migrate_iotg_qep
Jan 10, 2024
Merged

Add QEP test cases and plans from checkbox-iiotg-providers and iiotg provider (New)#901
pieqq merged 3 commits intocanonical:mainfrom
LiaoU3:migrate_iotg_qep

Conversation

@LiaoU3
Copy link
Copy Markdown
Contributor

@LiaoU3 LiaoU3 commented Dec 21, 2023

Description

I move the MEI related test cases from checkbox-iiotg-provider to the iiotg provider in checkbox monorepo.

Resolved issues

N/A

Documentation

N/A

Tests

I run testplan qep-full you can say Quadrature Encoder Peripheral (QEP) tests on EHL (202306-31656) which support QEP.

submission: https://certification.canonical.com/hardware/202306-31656/submission/349195/

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4310d65) 36.58% compared to head (f8082b8) 36.78%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #901      +/-   ##
==========================================
+ Coverage   36.58%   36.78%   +0.20%     
==========================================
  Files         310      310              
  Lines       34639    34637       -2     
  Branches     5965     5965              
==========================================
+ Hits        12671    12740      +69     
+ Misses      21399    21328      -71     
  Partials      569      569              
Flag Coverage Δ
provider-base 5.99% <ø> (+0.49%) ⬆️
provider-iiotg 100.00% <ø> (ø)
providers ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR comes with new jobs, but no associated test plans. I had to create one manually to test them in Checkbox. Did you forget to add the test plan file, or is it expected?

Other than that, it looks OK to me, I just made a few suggestions below (the description text does not need \). You can accept the suggestions and create an associated commit directly inside GitHub in one click :)

LiaoU3 and others added 2 commits January 9, 2024 17:03
Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
Copy link
Copy Markdown
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

@pieqq pieqq merged commit 36d08c9 into canonical:main Jan 10, 2024
LiaoU3 added a commit to LiaoU3/checkbox that referenced this pull request Mar 20, 2024
* Add QEP test cases and plans from checkbox-iiotg-providers and iiotg provider

* Apply suggestions from code review

Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>

* Add qep testplan

---------

Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
binli pushed a commit to binli/checkbox that referenced this pull request Mar 22, 2024
* Add QEP test cases and plans from checkbox-iiotg-providers and iiotg provider

* Apply suggestions from code review

Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>

* Add qep testplan

---------

Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
@LiaoU3 LiaoU3 deleted the migrate_iotg_qep branch April 2, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants