Modify detection for usb-dwc3 to make it really detecting (Bugfix)#903
Merged
pieqq merged 1 commit intocanonical:mainfrom Jan 10, 2024
Merged
Modify detection for usb-dwc3 to make it really detecting (Bugfix)#903pieqq merged 1 commit intocanonical:mainfrom
pieqq merged 1 commit intocanonical:mainfrom
Conversation
LiaoU3
force-pushed
the
migrate_iotg_dwc3
branch
from
9072f2a to
690aa33
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
=======================================
Coverage 36.58% 36.58%
=======================================
Files 310 310
Lines 34639 34639
Branches 5965 5965
=======================================
Hits 12671 12671
Misses 21399 21399
Partials 569 569
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Collaborator
|
/canonical/self-hosted-runners/run-workflows 690aa33 |
pieqq
approved these changes
Jan 10, 2024
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
Does what's advertised, and provides information when the driver or module is not detected. All good to me.
LiaoU3
added a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I migrate the usb-dwc3 test cases from checkbox-provider-iiotg. And we modify the tes jobs, because if we select the manifest for dwc3 to supported, then the
driverandmoduleshould be detected. Hence if those are not detected, it should be a fail.Resolved issues
N/A
Documentation
N/A
Tests
I run the tesplan
usb-dwc3-fullor you can sayDesignWare Core SuperSpeed USB 3.0 Controller (DWC3) testson Aaeon EHL (202306-31656).submission: https://certification.canonical.com/hardware/202306-31656/submission/349779/test-results/