Add test_image_checker in to checkbox_support to check the image (New)#911
Merged
pieqq merged 1 commit intocanonical:mainfrom Jan 8, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
==========================================
+ Coverage 36.58% 36.62% +0.04%
==========================================
Files 310 311 +1
Lines 34639 34665 +26
Branches 5965 5969 +4
==========================================
+ Hits 12671 12695 +24
Misses 21399 21399
- Partials 569 571 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LiaoU3
force-pushed
the
add_image_source_type_check
branch
from
df5deac to
eed2b93
Compare
pieqq
previously approved these changes
Jan 8, 2024
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
Thanks for the PR!
When I saw the title and the different methods (get_type, get_source), it took me a little bit of time to realize we were not talking about raster images, but rather ISO images 😆
It's working so I'll approve this PR, but I made a few suggestions below.
LiaoU3
force-pushed
the
add_image_source_type_check
branch
from
eed2b93 to
f992fcf
Compare
pieqq
approved these changes
Jan 8, 2024
LiaoU3
added a commit
to LiaoU3/checkbox
that referenced
this pull request
Jan 9, 2024
…ore images (New) (canonical#911) Add checkbox-support-image_checker and resource job image_source_and_type Originally copied from https://git.launchpad.net/~checkbox-dev/checkbox-iiotg/+git/checkbox-provider-intliotg/tree/bin/image_checker.py
LiaoU3
added a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
…ore images (New) (canonical#911) Add checkbox-support-image_checker and resource job image_source_and_type Originally copied from https://git.launchpad.net/~checkbox-dev/checkbox-iiotg/+git/checkbox-provider-intliotg/tree/bin/image_checker.py
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
…ore images (New) (canonical#911) Add checkbox-support-image_checker and resource job image_source_and_type Originally copied from https://git.launchpad.net/~checkbox-dev/checkbox-iiotg/+git/checkbox-provider-intliotg/tree/bin/image_checker.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After adding this
image_checker.pyand resource jobimage_source_and_type, all of the jobs can use this resource job to get thetype(classic, core) andsource(stock, oem) of the current image.Resolved issues
N/A
Documentation
N/A
Tests
(base) vincent@vincent-XPS-9320:~$ checkbox-support-image_checker -t -s type: classic source: stock