Skip to content

Check the installed package instead of from ubuntu-archive (bugfix)#914

Merged
kissiel merged 1 commit intomainfrom
lp2027655
Jan 7, 2024
Merged

Check the installed package instead of from ubuntu-archive (bugfix)#914
kissiel merged 1 commit intomainfrom
lp2027655

Conversation

@kissiel
Copy link
Copy Markdown
Contributor

@kissiel kissiel commented Jan 6, 2024

This PR is the rebased version of the following PR:
#640

It might be quicker to land it with this PR than go chasing rebases with the original one.

[p/b/b/check-ubuntu-desktop-recommends.sh] (LP: #2027655)
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cac5044) 36.58% compared to head (9d975c1) 36.58%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #914   +/-   ##
=======================================
  Coverage   36.58%   36.58%           
=======================================
  Files         310      310           
  Lines       34639    34639           
  Branches     5965     5965           
=======================================
  Hits        12671    12671           
  Misses      21399    21399           
  Partials      569      569           
Flag Coverage Δ
provider-base 5.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for doing this! +1

@kissiel kissiel merged commit 67ab000 into main Jan 7, 2024
@kissiel kissiel deleted the lp2027655 branch January 7, 2024 22:26
LiaoU3 pushed a commit to LiaoU3/checkbox that referenced this pull request Jan 9, 2024
…anonical#914)

[p/b/b/check-ubuntu-desktop-recommends.sh] (LP: #2027655)

Co-authored-by: Jeremy Szu <jeremy.szu@canonical.com>
LiaoU3 pushed a commit to LiaoU3/checkbox that referenced this pull request Mar 20, 2024
…anonical#914)

[p/b/b/check-ubuntu-desktop-recommends.sh] (LP: #2027655)

Co-authored-by: Jeremy Szu <jeremy.szu@canonical.com>
binli pushed a commit to binli/checkbox that referenced this pull request Mar 22, 2024
…anonical#914)

[p/b/b/check-ubuntu-desktop-recommends.sh] (LP: #2027655)

Co-authored-by: Jeremy Szu <jeremy.szu@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants