Add trigger and needs constraint to promotion workflow (infra)#921
Merged
Add trigger and needs constraint to promotion workflow (infra)#921
Conversation
Hook25
changed the title
kissiel
approved these changes
Jan 9, 2024
Contributor
kissiel
left a comment
kissiel
left a comment
There was a problem hiding this comment.
The double apt update is needed indeed. Once for potential curl installation, and the other after we add the PPA.
Good changes, +1
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
…ical#921) Add needs constraint to promotion workflow
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
…ical#921) Add needs constraint to promotion workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have decided that the promotion to the beta channel of the snap is governed by the moving target that is the
betabranch. Once that branch is moved, the currentedgeversion of the snap/deb must be promoted to stable. This introduces the mechanism to the beta promotion workflow along a sanity check to avoid race conditions (namely, the last "green" run of the daily build must have happened on the commit pointed bybeta, else something went wrong!).Resolved issues
Resolves: CHECKBOX-1056
Documentation
N/A (This is just the workflow work, it works as described before)
Tests
The mechanism was partially validated offline, it is easier to iterate online on the last details