Conversation
Modified the English of the code review section for readability, but no intent to change meaning.
Co-authored-by: kissiel <maciej.kisielewski@canonical.com>
Co-authored-by: kissiel <maciej.kisielewski@canonical.com>
Co-authored-by: kissiel <maciej.kisielewski@canonical.com>
mz2
approved these changes
Jan 10, 2024
Contributor
mz2
left a comment
mz2
left a comment
There was a problem hiding this comment.
Looks good to me, addresses review feedback too. Merging =>
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
* Update CONTRIBUTING.md Modified the English of the code review section for readability, but no intent to change meaning.
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
* Update CONTRIBUTING.md Modified the English of the code review section for readability, but no intent to change meaning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modified the English of the code review section for readability, but no intent to change meaning.
Resolved issues
None, opinion on documentation only.
Documentation
n/a
Tests
N/a