fix detecting insertion/removal of tb3 drive (BugFix)

[kissiel]

Description

Fix Thunderbolt "insert" and "remove" tests on Classic.

On classic images the "scsi detection" that was employed by the job definition did not work.
Historically we've had two version of insertion/removal detection code: one for Classic and one for Core. The patch that introduced the tests was using this approach, but in fact it was it was not needed, as the version provided by the implementation in checkbox-support (that was used exclusively for UC) works on both.

The patch I'm proposing here makes Checkbox use the working one, regardless of whether we're running on UC or Classic, thus fixing the problem

Resolved issues

Fixes: #97, CHECKBOX-1123

Documentation

No changes.

Tests

Tested on classic image with the tb3 drive.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff8ab68) 37.43% compared to head (9994ee9) 37.49%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
+ Coverage   37.43%   37.49%   +0.05%     
==========================================
  Files         313      313              
  Lines       34742    34794      +52     
  Branches     5870     5982     +112     
==========================================
+ Hits        13006    13046      +40     
+ Misses      21191    21168      -23     
- Partials      545      580      +35     

Flag	Coverage Δ
provider-base	6.91% <ø> (+0.24%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yphus]

The insert/removal jobs now run the same script on core/classic but the storage test still use removable_storage_test.py -s 268400000 scsi for thunderbolt. Have you tested it too?

[kissiel]

The insert/removal jobs now run the same script on core/classic but the storage test still use removable_storage_test.py -s 268400000 scsi for thunderbolt. Have you tested it too?

Yes. I got this result:

Found the following mounted scsi partitions:
    /dev/nvme1n1p1 : /tmp/tmp7ok46dc5 : None bits/s
--------------------
/dev/nvme1n1p1 (Total Data Size / iteration: 255.9662 MB):
        [Iteration 0] Average Speed: 1085.5509
        Summary:
                Total Data Attempted: 255.9662 MB
                Total Time to write: 0.2358 secs
                Average Write Time: 0.2358 secs
                Average Write Speed: 1085.5509 MB/s

[yphus]

+1