Skip to content

Pad every frontend snap with workaround part (infra) #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kissiel merged 2 commits into from
Jan 12, 2024
Merged

Pad every frontend snap with workaround part (infra) #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ede4b49
Add new workaround part to snapcraft.yaml
Hook25 Jan 12, 2024
42cf7b0
Added header to file and updated comment
Hook25 Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions checkbox-snap/series_classic16/snap/snapcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,16 @@ parts:
plugin: dump
source: .
stage: [config_vars]
workaround-automated-review-issue:
plugin: nil
override-build: |
# This is a workaround for an upstream bug in the automated snap review tool
# remove this once this issue is resolved:
# https://bugs.launchpad.net/review-tools/+bug/2049093
# Note: this cats /dev/urandom because the squashfs will collapse any
# predictable output to less than the desired size making this
# ineffective
echo "This file is a workaround for a bug in the automated snap review tool" > $SNAPCRAFT_PART_INSTALL/size_workaround
echo "this only contains random bytes to pad the snap to 16kb" >> $SNAPCRAFT_PART_INSTALL/size_workaround
echo "see: https://bugs.launchpad.net/review-tools/+bug/2049093" >> $SNAPCRAFT_PART_INSTALL/size_workaround
cat /dev/urandom | head -c 16384 >> $SNAPCRAFT_PART_INSTALL/size_workaround
13 changes: 13 additions & 0 deletions checkbox-snap/series_classic18/snap/snapcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,16 @@ parts:
plugin: dump
source: .
stage: [config_vars]
workaround-automated-review-issue:
plugin: nil
override-build: |
# This is a workaround for an upstream bug in the automated snap review tool
# remove this once this issue is resolved:
# https://bugs.launchpad.net/review-tools/+bug/2049093
# Note: this cats /dev/urandom because the squashfs will collapse any
# predictable output to less than the desired size making this
# ineffective
echo "This file is a workaround for a bug in the automated snap review tool" > $SNAPCRAFT_PART_INSTALL/size_workaround
echo "this only contains random bytes to pad the snap to 16kb" >> $SNAPCRAFT_PART_INSTALL/size_workaround
echo "see: https://bugs.launchpad.net/review-tools/+bug/2049093" >> $SNAPCRAFT_PART_INSTALL/size_workaround
cat /dev/urandom | head -c 16384 >> $SNAPCRAFT_PART_INSTALL/size_workaround
13 changes: 13 additions & 0 deletions checkbox-snap/series_classic20/snap/snapcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,16 @@ parts:
plugin: dump
source: .
stage: [config_vars]
workaround-automated-review-issue:
plugin: nil
override-build: |
# This is a workaround for an upstream bug in the automated snap review tool
# remove this once this issue is resolved:
# https://bugs.launchpad.net/review-tools/+bug/2049093
# Note: this cats /dev/urandom because the squashfs will collapse any
# predictable output to less than the desired size making this
# ineffective
echo "This file is a workaround for a bug in the automated snap review tool" > $SNAPCRAFT_PART_INSTALL/size_workaround
echo "this only contains random bytes to pad the snap to 16kb" >> $SNAPCRAFT_PART_INSTALL/size_workaround
echo "see: https://bugs.launchpad.net/review-tools/+bug/2049093" >> $SNAPCRAFT_PART_INSTALL/size_workaround
cat /dev/urandom | head -c 16384 >> $SNAPCRAFT_PART_INSTALL/size_workaround
13 changes: 13 additions & 0 deletions checkbox-snap/series_classic22/snap/snapcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,16 @@ parts:
source: .
build-attributes: [no-patchelf]
stage: [config_vars]
workaround-automated-review-issue:
plugin: nil
override-build: |
# This is a workaround for an upstream bug in the automated snap review tool
# remove this once this issue is resolved:
# https://bugs.launchpad.net/review-tools/+bug/2049093
# Note: this cats /dev/urandom because the squashfs will collapse any
# predictable output to less than the desired size making this
# ineffective
echo "This file is a workaround for a bug in the automated snap review tool" > $SNAPCRAFT_PART_INSTALL/size_workaround
echo "this only contains random bytes to pad the snap to 16kb" >> $SNAPCRAFT_PART_INSTALL/size_workaround
echo "see: https://bugs.launchpad.net/review-tools/+bug/2049093" >> $SNAPCRAFT_PART_INSTALL/size_workaround
cat /dev/urandom | head -c 16384 >> $SNAPCRAFT_PART_INSTALL/size_workaround
13 changes: 13 additions & 0 deletions checkbox-snap/series_uc16/snap/snapcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,3 +106,16 @@ parts:
plugin: dump
source: .
stage: [config_vars]
workaround-automated-review-issue:
plugin: nil
override-build: |
# This is a workaround for an upstream bug in the automated snap review tool
# remove this once this issue is resolved:
# https://bugs.launchpad.net/review-tools/+bug/2049093
# Note: this cats /dev/urandom because the squashfs will collapse any
# predictable output to less than the desired size making this
# ineffective
echo "This file is a workaround for a bug in the automated snap review tool" > $SNAPCRAFT_PART_INSTALL/size_workaround
echo "this only contains random bytes to pad the snap to 16kb" >> $SNAPCRAFT_PART_INSTALL/size_workaround
echo "see: https://bugs.launchpad.net/review-tools/+bug/2049093" >> $SNAPCRAFT_PART_INSTALL/size_workaround
cat /dev/urandom | head -c 16384 >> $SNAPCRAFT_PART_INSTALL/size_workaround
13 changes: 13 additions & 0 deletions checkbox-snap/series_uc18/snap/snapcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,3 +110,16 @@ parts:
plugin: dump
source: .
stage: [config_vars]
workaround-automated-review-issue:
plugin: nil
override-build: |
# This is a workaround for an upstream bug in the automated snap review tool
# remove this once this issue is resolved:
# https://bugs.launchpad.net/review-tools/+bug/2049093
# Note: this cats /dev/urandom because the squashfs will collapse any
# predictable output to less than the desired size making this
# ineffective
echo "This file is a workaround for a bug in the automated snap review tool" > $SNAPCRAFT_PART_INSTALL/size_workaround
echo "this only contains random bytes to pad the snap to 16kb" >> $SNAPCRAFT_PART_INSTALL/size_workaround
echo "see: https://bugs.launchpad.net/review-tools/+bug/2049093" >> $SNAPCRAFT_PART_INSTALL/size_workaround
cat /dev/urandom | head -c 16384 >> $SNAPCRAFT_PART_INSTALL/size_workaround
13 changes: 13 additions & 0 deletions checkbox-snap/series_uc20/snap/snapcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,3 +110,16 @@ parts:
plugin: dump
source: .
stage: [config_vars]
workaround-automated-review-issue:
plugin: nil
override-build: |
# This is a workaround for an upstream bug in the automated snap review tool
# remove this once this issue is resolved:
# https://bugs.launchpad.net/review-tools/+bug/2049093
# Note: this cats /dev/urandom because the squashfs will collapse any
# predictable output to less than the desired size making this
# ineffective
echo "This file is a workaround for a bug in the automated snap review tool" > $SNAPCRAFT_PART_INSTALL/size_workaround
echo "this only contains random bytes to pad the snap to 16kb" >> $SNAPCRAFT_PART_INSTALL/size_workaround
echo "see: https://bugs.launchpad.net/review-tools/+bug/2049093" >> $SNAPCRAFT_PART_INSTALL/size_workaround
cat /dev/urandom | head -c 16384 >> $SNAPCRAFT_PART_INSTALL/size_workaround
13 changes: 13 additions & 0 deletions checkbox-snap/series_uc22/snap/snapcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,3 +112,16 @@ parts:
source: .
build-attributes: [no-patchelf]
stage: [config_vars]
workaround-automated-review-issue:
plugin: nil
override-build: |
# This is a workaround for an upstream bug in the automated snap review tool
# remove this once this issue is resolved:
# https://bugs.launchpad.net/review-tools/+bug/2049093
# Note: this cats /dev/urandom because the squashfs will collapse any
# predictable output to less than the desired size making this
# ineffective
echo "This file is a workaround for a bug in the automated snap review tool" > $SNAPCRAFT_PART_INSTALL/size_workaround
echo "this only contains random bytes to pad the snap to 16kb" >> $SNAPCRAFT_PART_INSTALL/size_workaround
echo "see: https://bugs.launchpad.net/review-tools/+bug/2049093" >> $SNAPCRAFT_PART_INSTALL/size_workaround
cat /dev/urandom | head -c 16384 >> $SNAPCRAFT_PART_INSTALL/size_workaround