Skip to content

Cut down time it takes to run base provider unit tests by 95% (Infra) #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hook25 merged 1 commit into from
Jan 17, 2024
Merged

Cut down time it takes to run base provider unit tests by 95% (Infra) #943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion providers/base/tests/test_pipewire_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,9 @@ def test_wpctl_output_succ(self, mock_checkout):
'1'],
universal_newlines=True)

@patch("time.sleep")
@patch("subprocess.check_output")
def test_wpctl_output_fail(self, mock_checkout):
def test_wpctl_output_fail(self, mock_checkout, _):
vc = VolumeController(type='input', logger=MagicMock())
mock_checkout.side_effect = subprocess.CalledProcessError(2, "echo")
with self.assertRaises(SystemExit) as cm:
Expand Down
7 changes: 4 additions & 3 deletions providers/base/tests/test_pipewire_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,9 +385,9 @@ def test_wrong_gst_pipeline_device(self, mock_checkout):
mock_checkout.return_value = self.device
self.assertEqual(PipewireTestError.NO_SPECIFIC_DEVICE,
pt.gst_pipeline("pipe", 10, "qoo"))

@patch("time.sleep")
@patch("subprocess.check_output")
def test_gst_pipeline(self, mock_checkout):
def test_gst_pipeline(self, mock_checkout, _):
pt = PipewireTest()

mock_checkout.return_value = self.device
Expand Down Expand Up @@ -485,8 +485,9 @@ class MonitorActivePortTests(unittest.TestCase):
}
}]"""

@patch("time.sleep")
@patch("subprocess.check_output")
def test_couldnt_detect_change(self, mock_checkout):
def test_couldnt_detect_change(self, mock_checkout, _):
pt = PipewireTest()

mock_checkout.return_value = self.before_device
Expand Down