Renamed packaging.py to packaging_metadata.py (Bugfix)#944
Merged
Conversation
007111d to
230a996
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
==========================================
+ Coverage 39.18% 39.19% +0.01%
==========================================
Files 315 315
Lines 34899 34899
Branches 5972 5972
==========================================
+ Hits 13676 13680 +4
+ Misses 20610 20608 -2
+ Partials 613 611 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This change was made to avoid naming conflicts when importing the packaging module from packaging.py
5f88f94 to
3399962
Compare
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
* Renamed packaging.py to packaging_metadata.py This change was made to avoid naming conflicts when importing the packaging module from packaging.py * Added tests for category outcome map * Formatted test state
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
* Renamed packaging.py to packaging_metadata.py This change was made to avoid naming conflicts when importing the packaging module from packaging.py * Added tests for category outcome map * Formatted test state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was made to avoid naming conflicts when importing the packaging module from packaging.py
Description
When running unit tests using the
unittestmodule we run into an import error:This was because the python file had the same name as the module we were importing.
Resolved issues
Documentation
No new Documentation changes
Tests
Running the unit tests works without any issue:
Running
./manage.py packagingworks the same as before. In my case, I had to modify also one of the gitignored files to make it work,checkbox-ng/checkbox_ng.egg-info/entry_points.txtbut that should not be necessary if you setup the package again.