Rename ARM Vector Floating Point templates to avoid clash (BugFix)#949
Merged
Rename ARM Vector Floating Point templates to avoid clash (BugFix)#949
Conversation
These two templates use the same `id` which is a problem when ensuring every template has a unique id field.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #949 +/- ##
=======================================
Coverage 38.98% 38.98%
=======================================
Files 315 315
Lines 34893 34893
Branches 5971 5971
=======================================
Hits 13604 13604
Misses 20678 20678
Partials 611 611
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pieqq
force-pushed
the
1074-rename-vfp-support-jobs
branch
from
75ff2f2 to
b5cbfb0
Compare
kissiel
approved these changes
Jan 22, 2024
Contributor
kissiel
left a comment
kissiel
left a comment
There was a problem hiding this comment.
Looks good!
+1
Now the question is whether there's a commercial project using the previous naming scheme...
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
…anonical#949) * Rename ARM Vector Floating Point template units to avoid clash These two templates use the same `id` which is a problem when ensuring every template has a unique id field. * Update test plans accordingly
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
…anonical#949) * Rename ARM Vector Floating Point template units to avoid clash These two templates use the same `id` which is a problem when ensuring every template has a unique id field. * Update test plans accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These two templates use the same
idwhich is a problem when ensuring every template has a unique id field.Resolved issues
This will help with CHECKBOX-1074
Documentation
Tests