Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
=======================================
Coverage 39.18% 39.18%
=======================================
Files 315 315
Lines 34899 34899
Branches 5972 5972
=======================================
Hits 13676 13676
Misses 20610 20610
Partials 613 613
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kissiel
approved these changes
Jan 20, 2024
Contributor
kissiel
left a comment
kissiel
left a comment
There was a problem hiding this comment.
TYVM! +1
PS The other way would be to run python3 the_inxi_module, I guess.
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the checkbox-ng debian packaging to always install
inxias an executable.Resolved issues
Fixes #955
Documentation
N/A
Tests
Tested the binary build in LXC (18.04) using
dpkg-buildpackage -b -d -uc -usInxi is now packaged with the following permissions:
-rwxr-xr-x root/root 1263081 2023-06-14 06:35 ./usr/lib/python3/dist-packages/plainbox/vendor/inxi