Changed variable name to environment from environ (bugfix)#961
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
=======================================
Coverage 39.19% 39.19%
=======================================
Files 315 315
Lines 34898 34899 +1
Branches 5972 5972
=======================================
+ Hits 13679 13680 +1
Misses 20608 20608
Partials 611 611
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
…#961) Changed variable name to environment from environ
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
…#961) Changed variable name to environment from environ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixed the test but executing it reveals that it was also wrong. The section is called
environmentnotenviron. This fixes it and updates the function that is used to check to another one because unittest mocks work differently (and the other returns False on unittest and True on pytest)Resolved issues
N/A
Documentation
N/A
Tests
N/A