Build with charmcraft

[addyess]

• Adjustments to build reactive charm using charmcraft

Details

• negotiable drop of focal, addition of noble support.

[mateoflorido]

Great, thanks for adding support for Noble!

[mateoflorido]

Just out of curiosity, why the charm needs a VM now?

[addyess]

it's probably just force of habit now for me to avoid lxd priviledged containers. The docker-registry charm actually runs the registry in a docker container on the machine. maybe it's not necessary... would you like me to remove this and see how things go without it?

[addyess]

yep, @mateoflorido -- the reason this was there is now clear:

i had issues running in lxd on noble:

2025-04-03 16:11:07 WARNING unit.docker-registry-noble/0.install logger.go:60 docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error jailing process inside rootfs: pivot_root .: permission denied: unknown.
2025-04-03 16:11:07 ERROR unit.docker-registry-noble/0.juju-log server.go:326 Could not create new container: registry
2025-04-03 16:11:07 ERROR unit.docker-registry-noble/0.juju-log server.go:326 Hook error:
Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-docker-registry-noble-0/.venv/lib/python3.12/site-packages/charms/reactive/__init__.py", line 74, in main
    bus.dispatch(restricted=restricted_mode)
  File "/var/lib/juju/agents/unit-docker-registry-noble-0/.venv/lib/python3.12/site-packages/charms/reactive/bus.py", line 390, in dispatch
    _invoke(other_handlers)
  File "/var/lib/juju/agents/unit-docker-registry-noble-0/.venv/lib/python3.12/site-packages/charms/reactive/bus.py", line 359, in _invoke
    handler.invoke()
  File "/var/lib/juju/agents/unit-docker-registry-noble-0/.venv/lib/python3.12/site-packages/charms/reactive/bus.py", line 181, in invoke
    self._action(*args)
  File "/var/lib/juju/agents/unit-docker-registry-noble-0/charm/reactive/docker_registry.py", line 36, in start
    layer.docker_registry.start_registry()
  File "/var/lib/juju/agents/unit-docker-registry-noble-0/charm/lib/charms/layer/docker_registry.py", line 525, in start_registry
    subprocess.check_call(cmd)
  File "/usr/lib/python3.12/subprocess.py", line 413, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['docker', 'run', '-d', '-p', '5000:5000', '-p', '5001:5001', '--restart', 'unless-stopped', '-v', '/etc/docker/registry/config.yml:/etc/docker/registry/config.yml', '-v', '/srv/registry:/var/lib/registry', '--name', 'registry', 'registry:2']' returned non-zero exit status 126.