feat(Ceph): drop source

[kimanhou]

Done

• Drop source config key for Ceph RBD and CephFS drivers

Fixes #1877

QA

1. Run the LXD-UI:
   • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @Kxiru or @edlerd for access.
   • With a local copy of this branch, build and run as described in the docs.
2. Perform the following QA steps:
   • Create a storage pool, enter a name, select driver=Ceph
   • Make sure Source doesn't appear on the main configuration screen
   • Make sure Ceph OSD pool name appears on the Ceph specific screen
   • Save
   • Edit
   • Create a storage pool, enter a name, select driver=CephFS
   • Make sure Source doesn't appear on the main configuration screen
   • Make sure Path appears on the Ceph specific screen (it was already there)
   • Save
   • Edit

Screenshots

[webteam-app]

Demo

Jenkins

demos.haus

[roosterfish]

Hey @kimanhou, thanks for tackling this so quickly. Unfortunately I cannot access https://lxd-ui-1878.demos.haus/, but please see my comment.

[roosterfish]

Not sure if this is the right place here, but ceph.osd.pool_name should always be a valid option for a Ceph RBD pool no matter if storage_remote_drop_source is present or not.

Same as the [getPoolKey("cephfs_path")]: values.cephfs_path, below.

[roosterfish]

The pool name setting should be under the general "Ceph" tab as its a regular setting which is always available. Same for cephfs.path.

[kimanhou]

@roosterfish Like this ?

I removed source from the main configuration

[roosterfish]

One more comment. If you don't set ceph.osd.pool_name, LXD will set it to the name of the storage pool. I think this could also be reflected in the "inherited" column?

[edlerd]

Thanks for picking this task up so quickly. Some thoughts on the proposed changes below.

[kimanhou]

@roosterfish I opened a PR in LXD to update the description of Ceph OSD pool name, it will appear in help text in the UI. Is it clearer ?

canonical/lxd#17922

[edlerd]

Thanks for the iteration. Some further thoughts on the changes below.

[edlerd]

LGTM