Skip to content

Cluster links API and CLI#14884

Closed
kadinsayani wants to merge 37 commits intocanonical:mainfrom
kadinsayani:lxd-remotes
Closed

Cluster links API and CLI#14884
kadinsayani wants to merge 37 commits intocanonical:mainfrom
kadinsayani:lxd-remotes

Conversation

@kadinsayani
Copy link
Copy Markdown
Member

@kadinsayani kadinsayani commented Jan 29, 2025

Depends on #16165.

Introduces LXD cluster links, allowing for secure interaction between separate LXD clusters.

@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Jan 29, 2025
@kadinsayani kadinsayani force-pushed the lxd-remotes branch 3 times, most recently from 06209b4 to 0bfbd6f Compare January 29, 2025 23:32
@kadinsayani
Copy link
Copy Markdown
Member Author

kadinsayani commented Jan 29, 2025

The failing CodeQL security check is due to the join token being passed in as user input to the POST /1.0/site/join request - we use the addresses from the join token when calling GetRemoteCertificate. We do the same in lxd init interactive: https://github.com/canonical/lxd/blob/main/lxd/main_init_interactive.go#L175-L190.

@kadinsayani kadinsayani force-pushed the lxd-remotes branch 5 times, most recently from 7cbdfa6 to 3783d48 Compare February 4, 2025 21:30
@kadinsayani kadinsayani changed the title LXD: Server side remotes and remote clusters LXD: Sites Feb 4, 2025
@kadinsayani kadinsayani force-pushed the lxd-remotes branch 3 times, most recently from ed12163 to fa78411 Compare February 5, 2025 22:54
@kadinsayani kadinsayani force-pushed the lxd-remotes branch 10 times, most recently from a43ad68 to b5cd7ef Compare February 11, 2025 18:55
@kadinsayani kadinsayani force-pushed the lxd-remotes branch 2 times, most recently from ad2b200 to 64e9639 Compare February 11, 2025 19:24
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
…ink permissions

Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
…ink validation

Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>

This adds the cluster link API handlers and their associated functions.

Includes:
- `clusterLinksPost` handler
- `clusterLinkPost` handler
- `clusterLinkPut` handler
- `clusterLinkPatch` handler
- `clusterLinkDelete` handler
- `clusterLinksGet` handler
- `clusterLinkGet` handler
- `clusterLinkValidateConfig` function
- `updateClusterLink` function

Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
…tion

Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
With the addition of the new cluster link commands we're exceeding the
current limit.

Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
@kadinsayani
Copy link
Copy Markdown
Member Author

Closing until we are ready to revisit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Changes to the REST API Documentation Documentation needs updating

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants