[New] Add test submission schema version 1#6
Merged
douglasdotc merged 43 commits intomainfrom Dec 15, 2024
Merged
Conversation
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
douglasdotc
commented
Dec 4, 2024
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
douglasdotc
commented
Dec 4, 2024
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
tang-mm
reviewed
Dec 5, 2024
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
p-gentili
requested changes
Dec 6, 2024
p-gentili
left a comment
p-gentili
left a comment
There was a problem hiding this comment.
Some comments below but the biggest thing we're missing is the category_map which is AFAIK required.
douglasdotc
commented
Dec 10, 2024
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
pieqq
reviewed
Dec 10, 2024
Contributor
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
I had done an initial review... and forgot to submit it! :)
Trying again.
Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
…validator. Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
tang-mm
reviewed
Dec 12, 2024
tang-mm
reviewed
Dec 12, 2024
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
p-gentili
approved these changes
Dec 15, 2024
p-gentili
left a comment
p-gentili
left a comment
There was a problem hiding this comment.
I would get rid of any yarf mention for the time being.
Apart from that, LGTM!
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds our first version of the test submission schema following the JSON schema 2020-12 version
Resolved issues
CERT-2807
CERT-2812
Documentation
Generated
Tests