Skip to content

add env vars to the charm deployment#5575

Merged
jmuzina merged 2 commits intofeature/charmfrom
feature/charm-env-vars
Jul 11, 2025
Merged

add env vars to the charm deployment#5575
jmuzina merged 2 commits intofeature/charmfrom
feature/charm-env-vars

Conversation

@jmuzina
Copy link
Member

@jmuzina jmuzina commented Jul 9, 2025

Done

  • Add charm environment variables needed for external API calls (GitHub API, Google Search API)
  • Upgrades to flask-base 2.6.0 per recommendation by @samhotep - it loads FLASK_-prefixed env vars for us. Add flask secret key canonicalwebteam.flask-base#87
  • Configures gunicorn to avoid timing out on requests to external APIs by increasing timeout threshold and adding an additional worker
  • Minor documentation tweak for how to authenticate / create the charmhub token

QA

  • Go to staging.vanillaframework.io (currently already deployed to PS6 with this charm).
  • Open the search bar, and enter any search query. See that the search is submitted and does not throw a 500 error. Ex: test query
  • Go to the contributors page and verify it does not throw a 500 error (displays contributors list)

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

@webteam-app
Copy link

@jmuzina jmuzina force-pushed the feature/charm-env-vars branch from e41a939 to bc0849b Compare July 10, 2025 14:30
@jmuzina jmuzina force-pushed the feature/charm-env-vars branch from 46ab256 to aaeabf2 Compare July 11, 2025 11:40
@jmuzina jmuzina force-pushed the feature/charm-env-vars branch from 6273bad to e23ea8f Compare July 11, 2025 14:08
@jmuzina jmuzina force-pushed the feature/charm-env-vars branch from 1179130 to d6c1864 Compare July 11, 2025 16:28
@jmuzina jmuzina marked this pull request as ready for review July 11, 2025 16:37
@jmuzina jmuzina requested a review from advl July 11, 2025 16:37
name: Deploy
# https://github.com/canonical/webteam-devops
uses: canonical/webteam-devops/.github/workflows/deploy.yaml@main
uses: canonical/webteam-devops/.github/workflows/deploy.yaml@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the version pinning ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're looking at an old version here, that pin was used for a bit in this PR while I was debugging some things, but it's been removed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants