add env vars to the charm deployment#5575
Merged
jmuzina merged 2 commits intofeature/charmfrom Jul 11, 2025
Merged
Conversation
e41a939 to
bc0849b
Compare
46ab256 to
aaeabf2
Compare
6273bad to
e23ea8f
Compare
1179130 to
d6c1864
Compare
advl
reviewed
Jul 11, 2025
advl
reviewed
Jul 11, 2025
advl
approved these changes
Jul 11, 2025
.github/workflows/deploy.yml
Outdated
| name: Deploy | ||
| # https://github.com/canonical/webteam-devops | ||
| uses: canonical/webteam-devops/.github/workflows/deploy.yaml@main | ||
| uses: canonical/webteam-devops/.github/workflows/deploy.yaml@v1 |
Member
Author
There was a problem hiding this comment.
You're looking at an old version here, that pin was used for a bit in this PR while I was debugging some things, but it's been removed now.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
FLASK_-prefixed env vars for us. Add flask secret key canonicalwebteam.flask-base#87QA
Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver convention