Conversation
| rootCmd.AddCommand(runCmd) | ||
|
|
||
| runCmd.PersistentFlags().StringP("token", "t", "", "function token to use") | ||
| runCmd.PersistentFlags().StringP("token", "t", "", "authorization token to use") |
There was a problem hiding this comment.
| runCmd.PersistentFlags().StringP("token", "t", "", "authorization token to use") | |
| runCmd.PersistentFlags().StringP("token", "t", "", "authentication token to use") |
There was a problem hiding this comment.
But we don't know who they are, just that they are authorized to run the function
There was a problem hiding this comment.
Ah interesting. Good point. I'm good either way in that case.
justin1121
left a comment
justin1121
left a comment
There was a problem hiding this comment.
LGTM so far. Just one typo i think.
ChrisFriesen
force-pushed
the
chris/rm-fn-tokens
branch
from
197b78b to
26f1ab4
Compare
ChrisFriesen
dismissed stale reviews from bendecoste and justin1121
via
518f329
| Reader: reader, | ||
| Insecure: insecure, | ||
| PcrSlice: pcrSlice, | ||
| Public: public, |
There was a problem hiding this comment.
Would this make this a breaking change for creating public functions then?
There was a problem hiding this comment.
Currently public functions are only denoted by the lack of functionTokenPublicKey sent to runtime as part of the deploy request, this change in runtime should gracefully be backwards compatible with the removal of function tokens for anyone using an old sdk/cli.
There was a problem hiding this comment.
Got it. Do these need to be merged in a certain order then?
There was a problem hiding this comment.
nvm I see what's going on in the runtime PR now.
3 participants
Looking at the Prometheus metric
function_token_authorizationfunction tokens are no longer being used.