Make modals type-safe#3166
Open
georgmu wants to merge 3 commits intocarbon-design-system:masterfrom
Open
Conversation
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
DCO Assistant Lite bot All contributors have signed the DCO. |
Author
|
I have read the DCO document and I hereby sign the DCO. |
Author
|
recheck |
it is now possible to create a modal and return a correctly typed ComponentRef. The BaseModal class is now also typed, allowing a correctly typed output value.
ddd3c6f to
fc5593e
Compare
Author
|
Any comments on my merge request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the
ModalService.create()was not type-safe. It introduced a typeT, but never used it.This merge request solves this by correctly typing the created type, allowing access to the instance.
Additionally, this change also types the return value emitted by
BaseModal.closeModal().This allows a type-safe data passing on close.
Changelog
Changed