fix(notification): sanitize toast innerHTML inputs#3238
Open
Lavn1sh wants to merge 1 commit intocarbon-design-system:masterfrom
Open
fix(notification): sanitize toast innerHTML inputs#3238Lavn1sh wants to merge 1 commit intocarbon-design-system:masterfrom
Lavn1sh wants to merge 1 commit intocarbon-design-system:masterfrom
Conversation
❌ Deploy Preview for carbon-components-angular failed.
|
|
DCO Assistant Lite bot All contributors have signed the DCO. |
Author
|
I have read the DCO document and I hereby sign the DCO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes carbon-design-system/carbon-components-angular#
Summary
Toast notifications bind
title,subtitle, andcaptionviainnerHTML.This change sanitizes those inputs at the component boundary to prevent XSS
when values originate from untrusted sources.
Changelog
Changed
title,subtitle, andcaptioninputs using AngularDomSanitizer.sanitize(SecurityContext.HTML, …)before binding toinnerHTMLRemoved
Additional context
Reference: https://tracker.ceph.com/issues/74770