Skip to content

Comments

fix(stack): allow grid children to shrink so codesnippet#21563

Open
naaa760 wants to merge 1 commit intocarbon-design-system:mainfrom
naaa760:fix/cod-snip-stack
Open

fix(stack): allow grid children to shrink so codesnippet#21563
naaa760 wants to merge 1 commit intocarbon-design-system:mainfrom
naaa760:fix/cod-snip-stack

Conversation

@naaa760
Copy link
Contributor

@naaa760 naaa760 commented Feb 17, 2026

fix: #21560

Short description:

  • codeSnippet no longer forces Stack to grow. Grid children now use min-inline-size: 0, so content stays within bounds and scrolls instead of widening the layout.

Changed

  • Vertical Stack: min-inline-size: 0 on children to allow shrinking
  • Horizontal Stack: min-block-size: 0 on children to allow shrinking

New

(none)

Removed

(none)

Testing / Reviewing

[ ] CodeSnippet in Stack inside a Tile shows scroll instead of expanding layout
[ ] Vertical spacing between Stack items still works

@naaa760 naaa760 requested a review from a team as a code owner February 17, 2026 20:06
@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.24%. Comparing base (b4692de) to head (50f0764).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21563      +/-   ##
==========================================
- Coverage   87.27%   87.24%   -0.04%     
==========================================
  Files         538      538              
  Lines       43487    43487              
  Branches     6719     6719              
==========================================
- Hits        37954    37940      -14     
- Misses       5372     5386      +14     
  Partials      161      161              
Flag Coverage Δ
main-packages 86.80% <ø> (ø)
web-components 87.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naaa760 please use the pull request template provided when opening a new pull request.

Two visual snapshots are failing: Form/Default and Form/with AI Label. It looks like it's isolated to mobile viewport sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CodeSnippet adjusts Stack's Width

2 participants