refactor(utilities): improve carousel and overflow typing#21618
Open
adamalston wants to merge 1 commit intocarbon-design-system:mainfrom
Open
refactor(utilities): improve carousel and overflow typing#21618adamalston wants to merge 1 commit intocarbon-design-system:mainfrom
adamalston wants to merge 1 commit intocarbon-design-system:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21618 +/- ##
==========================================
- Coverage 87.32% 87.29% -0.03%
==========================================
Files 538 538
Lines 43521 43521
Branches 6668 6731 +63
==========================================
- Hits 38003 37990 -13
- Misses 5357 5369 +12
- Partials 161 162 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue.
Improved carousel and overflow typing.
Changelog
Changed
Removed
Testing / Reviewing
The original goal was to remove all
HTMLElementtype assertions in thepackages/utilities. That goal evolved into making the implementations type safe, which required updates in several areas, includingdestroyEvents.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesMore details can be found in the pull request guide