Skip to content

Add missing repr(C) to WSABUF#26

Merged
carllerche merged 1 commit into
carllerche:v0.1.xfrom
EmbarkStudios:v0.1.x-repr-c-wsabuf
Oct 9, 2019
Merged

Add missing repr(C) to WSABUF#26
carllerche merged 1 commit into
carllerche:v0.1.xfrom
EmbarkStudios:v0.1.x-repr-c-wsabuf

Conversation

@repi
Copy link
Copy Markdown

@repi repi commented Oct 9, 2019

@lzutao caught this in the PR #25 review but has already been merged in then.

@repi
Copy link
Copy Markdown
Author

repi commented Oct 9, 2019

Without the repr(C) Rust (at least 1.38) did switch the order of the fields which makes the transmutes in the code not correct.

Think should yank 0.1.3 and publish a 0.1.4 with this.

Sorry that I missed it in the original PR :(

@carllerche carllerche merged commit 837c18e into carllerche:v0.1.x Oct 9, 2019
@repi repi deleted the v0.1.x-repr-c-wsabuf branch October 9, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants