Replace reqwest with bitreq HTTP client#1567
Closed
crodas wants to merge 2 commits intocashubtc:mainfrom
Closed
Conversation
crodas
force-pushed
the
feature/use-bitreq
branch
4 times, most recently
from
5b71631 to
d117579
Compare
Migrate the codebase from reqwest to bitreq for HTTP requests. This affects the wallet transport layer, OIDC client, CLI commands, and integration tests. - Replace reqwest::Client with bitreq::Client across all crates - Update HTTP request/response handling to use bitreq API - Remove reqwest and serde_urlencoded from workspace dependencies - Use url::form_urlencoded for URL encoding instead of serde_urlencoded - Adapt proxy configuration to bitreq's proxy API TODO: - [ ] Do something with accept_invalid_certs
crodas
force-pushed
the
feature/use-bitreq
branch
from
d117579 to
0733ae3
Compare
crodas
force-pushed
the
feature/use-bitreq
branch
from
2c65cf2 to
405f2f7
Compare
Collaborator
|
going to mark this as draft as we still have a few open questions, mostly around wasm support. |
2 tasks
Collaborator
Author
|
Closed until #1573 is merged |
Collaborator
Collaborator
|
Superseded by #1608 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1543
Migrate the codebase from reqwest to bitreq for HTTP requests. This affects the wallet transport layer, OIDC client, CLI commands, and integration tests.
TODO:
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just final-checkbefore committing