feat(nix): add pre-commit package into nix build inputs#1913
Closed
TheMhv wants to merge 1 commit intocashubtc:mainfrom
Closed
feat(nix): add pre-commit package into nix build inputs#1913TheMhv wants to merge 1 commit intocashubtc:mainfrom
TheMhv wants to merge 1 commit intocashubtc:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1913 +/- ##
=======================================
Coverage 64.32% 64.32%
=======================================
Files 329 329
Lines 55610 55610
=======================================
Hits 35770 35770
Misses 19840 19840 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Why is this needed? We don't have any pre-commit hooks. |
Contributor
Author
Recently i switched to another machine that was have a pre-commit config for other project. I misunderstand about that, sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just added the
pre-commitpackage in nix environmentNotes to the reviewers
Suggested CHANGELOG Updates
CHANGED
flake.nixADDED
pre-commitinto nix flakeREMOVED
FIXED
Checklist
just quick-checkbefore committingcrates/cdk-ffi)