Skip to content

feat(nix): add pre-commit package into nix build inputs#1913

Closed
TheMhv wants to merge 1 commit intocashubtc:mainfrom
TheMhv:feat/add_pre-commit_nix
Closed

feat(nix): add pre-commit package into nix build inputs#1913
TheMhv wants to merge 1 commit intocashubtc:mainfrom
TheMhv:feat/add_pre-commit_nix

Conversation

@TheMhv
Copy link
Copy Markdown
Contributor

@TheMhv TheMhv commented Apr 20, 2026

Description

Just added the pre-commit package in nix environment


Notes to the reviewers


Suggested CHANGELOG Updates

CHANGED

  • flake.nix

ADDED

  • Add pre-commit into nix flake

REMOVED

FIXED


Checklist

  • I followed the code style guidelines
  • I ran just quick-check before committing
  • If the Wallet API was modified (added/removed/changed), I have reflected those changes in the FFI bindings (crates/cdk-ffi)

@github-project-automation github-project-automation bot moved this to Backlog in CDK Apr 20, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.32%. Comparing base (bbbcae7) to head (c7889ad).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1913   +/-   ##
=======================================
  Coverage   64.32%   64.32%           
=======================================
  Files         329      329           
  Lines       55610    55610           
=======================================
  Hits        35770    35770           
  Misses      19840    19840           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thesimplekid
Copy link
Copy Markdown
Collaborator

Why is this needed? We don't have any pre-commit hooks.

@TheMhv
Copy link
Copy Markdown
Contributor Author

TheMhv commented Apr 21, 2026

Why is this needed? We don't have any pre-commit hooks.

Recently i switched to another machine that was have a pre-commit config for other project.

I misunderstand about that, sorry!

@TheMhv TheMhv closed this Apr 21, 2026
@github-project-automation github-project-automation bot moved this from Backlog to Done in CDK Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants