Merged
Conversation
feat: Add created_time column to blind_signature table feat: Add created_time to blind_signature insertion feat: Add created_time column to proof table and update insert query feat: time on mint and melt quotes
There was a problem hiding this comment.
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- crates/cdk-sqlite/src/mint/migrations/20250406091754_mint_time_of_quotes.sql: Language not supported
- crates/cdk-sqlite/src/mint/migrations/20250406093755_mint_created_time_signature.sql: Language not supported
Comments suppressed due to low confidence (2)
crates/cdk-sqlite/src/mint/mod.rs:381
- Consider not updating 'created_time' on conflict; the creation timestamp should remain unchanged after the initial insert.
created_time = excluded.created_time,
crates/cdk-payment-processor/src/proto/payment_processor.proto:80
- [nitpick] If tracking the time when a quote is issued is required for consistency with other components, consider adding an 'issued_time' field to the MeltQuote message.
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just final-checkbefore committing