fix(wallabag): allow null values in non-null published_by field#268
Merged
fix(wallabag): allow null values in non-null published_by field#268
Conversation
It should be and (is considered?) an illegal value but exists for some users and that break the synchronization with the server. It doesn't seem to be a bug in wallabag but the their data importer doesn't validate the data before importing (at least for the Omnivore importer).
casimir
force-pushed
the
nullable-publisher
branch
from
be86d8e to
52e634f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should be and (is considered?) an illegal value but exists for some users and that break the synchronization with the server.
It doesn't seem to be a bug in wallabag's logic but the data importer doesn't validate the data before importing (at least for the Omnivore importer).
Fixes #266