feat: make saving articles possible when offline#320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While being a small part of the changes, the main change of this patch is the refactoring the ad-hoc code into a RemoteSyncer action. Saving an article is like all other actions now and is resillient to a lack of connection.
Most of the changes are a redesign of the Flutter ↔ iOS interop. After the failed attempt of #319, the strategy has shifted to using a headless Flutter engine communicating via a plugin. It feels like a hack but the implementation is simple and feels very sound. It can be reevaluated when Flutter has fixed the extension hosted rendering issue.
Fixes: #310 #312