Upgrade NLog to 4.5 RTM for .NET Core support

[jonorossi]

We are currently using NLog 4.4.0-beta13 to get .NET Core support, we need to upgrade to an RTM version once it is released.

[jonorossi]

The main NLog .NET Core issue for 4.4 that hasn't been closed is NLog/NLog#641.

[jonorossi]

New main issue for .NET Core support in NLog: NLog/NLog#1559

[jonorossi]

The NLog guys have gone quiet since July so it might be time to drop NLog 4.4 beta support with .NET Core support from Castle Core 4.0 and revert back to NLog 4.3.x. It'll unblock us from not being able to release a 4.0 final.

Thoughts?

[jonorossi]

NLog 4.x won't support .NET Core, that support will come in NLog 5.x because there are missing APIs that they have decided to wait until .NET Standard 2.0 before releasing something that will work, this won't happen until Q1 2017.

http://nlog-project.org/2016/10/30/nlog-roadmap-netcore-structural-logging.html

Decision made, we'll revert to the stable NLog, 4.3.x, which unblocks us to release Castle Core v4 final. Will remove this task from the milestone when the change is in.

[DixonDs]

Are there any estimates when Castle.Core 4.0 RTM will be released? We have a couple of libraries depended on it, which we keep as prerelease mainly because they have prerelease dependency Castle.Core

[jonorossi]

@DixonDs are you using NLog? This issue is about supporting NLog on .NET Core.

[DixonDs]

@jonorossi Sorry, that was probably a wrong issue to ask that question. I've just got an impression that it is the only outstanding issue that holding Castle.Core 4.0 release. Do you happen to have gitter.im channel?

[jonorossi]

@DixonDs no problem, nope no active chat room. I just added a log4net issue into the milestone too. I've just been swamped for the last few weeks so pull requests on these last two remaining issues would allow me to cut the release.

[thomaslevesque]

Hi @jonorossi, do you plan to release the logging integration packages along with the main library for 4.0? From what I understand, it might be a while before NLog is ready for .NET Core, and none of the integration projects have been migrated to .NET Core yet. It might be a good idea to release Castle.Core 4.0 alone for now, and release the integration packages later. What do you think?

(If I seem eager to see Castle.Core 4.0 released, it's because I am 😉... it's about the only thing keeping us from releasing FakeItEasy 3.0)

[jonorossi]

@thomaslevesque yes, logging integration packages will be released as they have been in the betas. As per my comment on Nov 15th, this issue is only still in the milestone until we revert to a stable NLog for .NET 4.x.

Sorry about not getting the final release out, I kept snoozing Blair's GitHub comment notification email from last month where he said you guys weren't in a rush for it, didn't know you were ready to release. I'll try to get it sorted tomorrow.

[thomaslevesque]

@jonorossi thanks! I don't want to rush you, I was just wondering if something was keeping you from releasing.