Fix MethodSignatureComparer to handle nested generics#303
Merged
jonorossi merged 3 commits intocastleproject:masterfrom Sep 21, 2017
Merged
Fix MethodSignatureComparer to handle nested generics#303jonorossi merged 3 commits intocastleproject:masterfrom
jonorossi merged 3 commits intocastleproject:masterfrom
Conversation
…generic as a return type are inherited and overriden. This is in reference to issue castleproject#297
…ds with the base method when they contain a nested generic as the return type. References issue castleproject#297
jonorossi
requested changes
Sep 20, 2017
| return false; | ||
| } | ||
| } | ||
| else if (x.GetGenericArguments().Length > 0) |
Member
There was a problem hiding this comment.
Could this use x.IsGenericType instead?
|
|
||
| for (var i = 0; i < xArgs.Length; ++i) | ||
| { | ||
| if (xArgs[i].GetTypeInfo().IsGenericParameter != yArgs[i].GetTypeInfo().IsGenericParameter) |
Member
There was a problem hiding this comment.
Could this loop just call EqualSignatureTypes(xArgs[i], yArgs[i])? This probably means this method isn't needed and the recursion could happen in EqualSignatureTypes instead.
If this method stays it is spelt wrong.
Author
|
Thank you @stakx and @jonorossi for reviewing. Pesky typos.... Good suggestions! Updated pull request. |
Member
|
@BitWizJason Great. Before merging I wanted to make sure you are happy with the email address on those commits, that email address isn't associated with your GitHub account. |
jonorossi
approved these changes
Sep 20, 2017
Author
|
@jonorossi Thank you for pointing that out. I updated my profile. It should be associated now. |
jonorossi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added test cases that demonstrate the issue in the first commit and a potential fix in the second commit.