Synchronize read/write accesses to NamingScope.GetUniqueName#383
Merged
1 commit merged intocastleproject:masterfrom Jun 18, 2018
Merged
Synchronize read/write accesses to NamingScope.GetUniqueName#3831 commit merged intocastleproject:masterfrom
NamingScope.GetUniqueName#3831 commit merged intocastleproject:masterfrom
Conversation
`NamingScope.GetUniqueName` maintains and updates counters in an un- synchronized `Dictionary<,>`. This writing method is currently called from a location that allows several concurrent readers. This changes `BaseProxyGenerator.ObtainProxyType` so that it goes from a read lock straight to a write lock. There seems little point in taking an upgradeable lock first if we're going to need a write lock anyway for all of the work.
| @@ -396,9 +396,9 @@ protected Type ObtainProxyType(CacheKey cacheKey, Func<string, INamingScope, Typ | |||
| } | |||
|
|
|||
| // This is to avoid generating duplicate types under heavy multithreaded load. | |||
Contributor
There was a problem hiding this comment.
nit, you could probably move the comment 'This is to avoid generating duplicate types under heavy multithreaded load' to just after 'See if an earlier lock holder populated the cache.'
Contributor
|
@stakx Looks beautiful to me! |
ghost
merged commit 
ghost
mentioned this pull request
stakx
added a commit
to stakx/Castle.Core
that referenced
this pull request
Jun 20, 2018
Closed
jonorossi
added a commit
that referenced
this pull request
Jun 20, 2018
Add entry to the changelog for #383
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NamingScope.GetUniqueNamemaintains and updates counters in an unsynchronizedDictionary<,>. This writing method is currently called from a location that allows several concurrent readers.This changes
BaseProxyGenerator.ObtainProxyTypeso that it goes from a read lock straight to a write lock. There seems little point in taking an upgradeable lock first if we're going to need a write lock anyway for all of the work. (Taking an upgradeable read lock first would only benefit the second, repeated cache check.)