Feature/492 add project icon to common props

[generik0]

Remove PackageIconUrl in favour of the new PackageIcon configuration

#492

[generik0]

Please dont complete. The AppVeyor is not added the "icon" / prakageicon to the nuspec. Maybe old msbuild?

[stakx]

@generik0, I noticed too that the icon doesn't appear to work, at least not in VS2017 which I'm still using. I've converted this PR to a "draft" (to prevent accidental merging) until this has been resolved. Hope that's OK with you.

[generik0]

@stakx That’s perfect thanks!
How can we move to VS2019?

[stakx]

How can we move to VS2019?

If you're thinking of the CI build, that would be done by changing appveyor.yml:

Core/appveyor.yml

Lines 1 to 2 in 0d12f9c

	image:
	- Visual Studio 2017

AppVeyor keeps a list of available worker images, which includes one called Visual Studio 2019.

Our CI build is currently broken due to a regression in Mono, perhaps it would be best to get that fixed first, and upgrade to the newer Visual Studio 2019 image at the same time.

(Are you positive that using the newer VS 2019 tooling will resolve the present issue?)

[generik0]

Let me know if I can help with anything :-)

[stakx]

@generik0 we've now switched to VS2019's toolchain on our AppVeyor CI Windows build in current master (6685222). Do you want to rebase this PR and see if the newer tooling resolves the remaining issue with the missing icon?

[generik0]

HI @stakx. Sorry about the delay. Busy with work and family. Haven't had the time I needed for anything else (excuses excuses)..
Now i have the projecticon and projecticonurl in the props

[stakx]

Looks good to me! I've tested the result in VS2017 and VS2019, and the package icons display correctly in both versions' NuGet Package Manager. Also, the build warning is gone, so I'd say, mission accomplished! 🚀

[stakx]

@generik0, thanks for contributing! Btw., no need to apologise for the delay... we've all got our lives aside from (unpaid!) work on open source projects. It's great you came back to finalize this! :-)