Mark DynamicProxy's internal classes as sealed#544
Closed
stakx wants to merge 1 commit intocastleproject:masterfrom
Closed
Mark DynamicProxy's internal classes as sealed#544stakx wants to merge 1 commit intocastleproject:masterfrom
sealed#544stakx wants to merge 1 commit intocastleproject:masterfrom
Conversation
stakx
force-pushed
the
dp/refactor/seal-internal-types
branch
2 times, most recently
from
88febef to
424af49
Compare
stakx
force-pushed
the
dp/refactor/seal-internal-types
branch
from
424af49 to
d3d900e
Compare
Member
Author
|
I'll close this for the moment, this turns out to be a nice refactoring (IMO) but there probably isn't as much benefit to this as I thought. |
jonorossi
reviewed
Jan 19, 2021
| using Castle.DynamicProxy.Generators.Emitters.SimpleAST; | ||
|
|
||
| internal abstract class ArgumentsUtil | ||
| internal static class ArgumentsUtil |
Member
There was a problem hiding this comment.
Would be good to at least get these static changes in. Shows how long ago these classes were first written to use abstract to prevent instantiation of the class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DynamicProxy's internals have been stable over the past few years, and now that they are no longer public (see #505), we can view their type hierarchy as essentially frozen—at least for the time being. Marking internal classes that have no subclasses of their own as
sealedformalizes this.Being able to recognize final classes at a glance can be helpful when we want to refactor them.
(A few refactorings are included here because the C# compiler will warn about / disallow new
protectedorvirtualmembers insealedtypes.)Update: Converting to draft, this PR should perhaps also devirtualize non-overridden members, and make them
privatewhere possible.