Fix NullReferenceException caused by null argument for custom attribute's array-typed ctor parameter #642
Merged
stakx merged 4 commits intocastleproject:masterfrom Dec 29, 2022
Conversation
(While not strictly necessary to fix the failing test, it still helps to reduce the amount of code we need to look at.)
This is where the `NullReferenceException` happens. The pre-existing comment here didn't explain *why* this special case is needed at all, which only became apparent when I temporarily removed it. Let's explain the intent behind the special case better, and move it inside an `if` that triggers only when the right conditions are present (which now excludes `null` values).
stakx
changed the title
NullReferenceException caused by null argument for custom attribute's array-typed ctor parameter
Member
Author
|
This is another straightforward change that probably doesn't need a full review. I'll likely go ahead and merge this quite soon. |
jonorossi
approved these changes
Dec 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #637. See commit messages for details.