Upgraded to Castle.Core 4.2.0 to 4.3.1. #413
Merged
3 commits merged intomasterfrom Jun 22, 2018
unknown repository
Merged
Conversation
ghost
requested review from
jonorossi
reviewed
Jun 22, 2018
CHANGELOG.md
Outdated
| ## Unreleased | ||
|
|
||
| Enhancements: | ||
| - Upgraded to Castle.Core 4.2.0 to 4.3.1. https://github.com/castleproject/Core/releases/tag/v4.3.1 (@fir3pho3nixx). |
Member
There was a problem hiding this comment.
Maybe just update the line below 😉:
- Upgraded Castle.Core from 4.2.0 to 4.3.0 (@Fir3pho3nixx, Upgraded Castle.Core from 4.2.0 to 4.3.0 #409)
Member
There was a problem hiding this comment.
Small nit (in response to @jonorossi's comment on this), I guess it should read #413 (this PR) instead of #409 (a previous PR).
jonorossi
approved these changes
Jun 22, 2018
stakx
reviewed
Jun 22, 2018
Member
stakx
left a comment
stakx
left a comment
There was a problem hiding this comment.
Apart from the changelog entry, which looks a little funky right now, looks good to me!
CHANGELOG.md
Outdated
| ## Unreleased | ||
|
|
||
| Enhancements: | ||
| - Upgraded to Castle.Core 4.2.0 to 4.3.1. https://github.com/castleproject/Core/releases/tag/v4.3.1 (@fir3pho3nixx). |
Member
There was a problem hiding this comment.
Small nit (in response to @jonorossi's comment on this), I guess it should read #413 (this PR) instead of #409 (a previous PR).
Author
|
Thanks for checking, did this at 02:00 in the morning. :) |
stakx
approved these changes
Jun 22, 2018
Member
|
Did I miss something? The changelog still has 2 entries for the same release: |
Author
|
Will fix. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/castleproject/Core/releases/tag/v4.3.1